-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pointing frame updates #814
Pointing frame updates #814
Conversation
What does "et_" refer to in many of the variable names. Is this ephemeris time? |
Yes. That is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed most of the code and have some feedback. I ran out of time and haven't done an in-depth review of the tests. I will plan to come finish my review after school pickup or sometime this evening.
imap_processing/tests/spice/test_data/IMAP_spacecraft_attitude.bc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for addressing comments.
5c010cd
into
IMAP-Science-Operations-Center:dev
Change Summary
Overview
Adds ability to combine different pointings into the frame kernel.
Updated Files
Testing
Necessary test data:
IMAP_spacecraft_attitude.bc
imap_pointing_frame.bc